Skip to content

TST(string dtype): Resolve some HDF5 xfails #60615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 29, 2024
Merged

TST(string dtype): Resolve some HDF5 xfails #60615

merged 3 commits into from
Dec 29, 2024
+36 −17

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

The behavior here is that if you write out strings using object dtype, then you still get the inferred string dtype when reading back in. That is, we (likely) do not round-trip dtypes if the value of future.infer_string is different when reading/writing.

@rhshadrach rhshadrach added IO HDF5 read_hdf, HDFStore Strings String extension data type and string data labels Dec 29, 2024
@mroeschke mroeschke added this to the 2.3 milestone Dec 29, 2024
@mroeschke mroeschke merged commit 2edc7c9 into pandas-dev:main Dec 29, 2024
55 checks passed
@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Dec 29, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 2edc7c9ad9a8b2e1f8df981def5b5b0c434d9ab0
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #60615: TST(string dtype): Resolve some HDF5 xfails'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60615-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60615 on branch 2.3.x (TST(string dtype): Resolve some HDF5 xfails)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@mroeschke
Copy link
Member

Thanks @rhshadrach

rhshadrach added a commit to rhshadrach/pandas that referenced this pull request Dec 30, 2024
@rhshadrach
Backport PR pandas-dev#60615: TST(string dtype): Resolve some HDF5 xf…
a993738 
…ails
@rhshadrach
Copy link
Member Author

Opened manual backport: #60626

@rhshadrach rhshadrach deleted the str_xfail_pytables branch December 30, 2024 14:02
mroeschke pushed a commit that referenced this pull request Dec 30, 2024
@rhshadrach
Backport PR #60615: TST(string dtype): Resolve some HDF5 xfails (#60626)
c24ac2f
mroeschke pushed a commit that referenced this pull request Jan 21, 2025
@rhshadrach
Backport PR #60713: TST(string dtype): Resolve xfail in test_base.py (#…
36d34a1 
…60742)

* Backport PR #60615: TST(string dtype): Resolve some HDF5 xfails

* Backport PR #60713: TST(string dtype): Resolve xfail in test_base.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
IO HDF5 read_hdf, HDFStore Strings String extension data type and string data
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@rhshadrach @mroeschke